Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): add cache as official exported member #5315

Closed
wants to merge 1 commit into from

Conversation

ImBIOS
Copy link

@ImBIOS ImBIOS commented Mar 10, 2025

fix #5314

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 4a1e553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:29am

@LekoArts
Copy link
Member

Hello, thanks for your PR!
Please add a description to your PR so that future readers can understand what was changed here.

For the change itself, I wouldn't want us to make the whole cache folder/file a public API since we only want to surface this one specific type.

So please change your PR to add the re-export of the type to https://github.com/clerk/javascript/blob/main/packages/expo/src/index.ts so that one can do this in the future:

import type { TokenCache } from '@clerk/clerk-expo'

@LekoArts LekoArts self-assigned this Mar 10, 2025
@wobsoriano
Copy link
Member

wobsoriano commented Mar 15, 2025

Hi @ImBIOS, thanks for the PR! We're doing some improvements to the Expo SDK and it includes the suggestion of @LekoArts, and we addressed it in another PR #5358.

Thanks again 🫡 We appreciate the efforts.

@wobsoriano wobsoriano closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module '@clerk/clerk-expo/dist/cache/types' or its corresponding type declarations. ts(2307)
4 participants