-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shared,types): Move constants from types to shared #4716
chore(shared,types): Move constants from types to shared #4716
Conversation
🦋 Changeset detectedLatest commit: b785ac8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case we would like to introduce a new OAuth or Web3 provider, should we update both @clerk/types
and @clerk/shared
packages moving forward? or just the @clerk/shared
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the new subpaths to the files
array of package.json
Description
This PR deprecate the runtime utilities exported from
@clerk/types
and moves only the used ones from@clerk/shared
.Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change