Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chrome-extension): Poll for new active sessions #3616

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jun 21, 2024

Description

Polls for active session changes allowing for synchronizing newly authenticated users after the extension has been opened.

Fixes SDK-1843

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski self-assigned this Jun 21, 2024
Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 88bc372

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/chrome-extension Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski tmilewski force-pushed the feat.chrome-ext/poll-for-active-session branch from 43ac39e to 88bc372 Compare June 24, 2024 21:38
@tmilewski tmilewski marked this pull request as ready for review June 24, 2024 21:38
@tmilewski tmilewski requested a review from a team June 24, 2024 21:38
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • I wonder if we have checked that the opposite flow works. User logins to chrome extension and session is synced to website.

@tmilewski
Copy link
Member Author

LGTM

  • I wonder if we have checked that the opposite flow works. User logins to chrome extension and session is synced to website.

It's not possible in this fashion. We could, in theory, set the cookies to the permissioned domains from the extension.

@tmilewski tmilewski merged commit 94a8e84 into main Jun 25, 2024
15 checks passed
@tmilewski tmilewski deleted the feat.chrome-ext/poll-for-active-session branch June 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants