Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Remove commitlint as part of pre-commit checks #3407

Merged
merged 4 commits into from
May 21, 2024

Conversation

brkalow
Copy link
Member

@brkalow brkalow commented May 21, 2024

Description

Remove commitlint running as part of pre-commit checks. Instead, run it on the PR title. Due to squash merging, this will ensure that commits to main have formatted messages, but commits to branches unchecked. ⏩

fixes SDK-1753

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: ef39171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brkalow brkalow changed the title chore(repo): remove commitlint as part of pre-commit checks chore(repo): Remove commitlint as part of pre-commit checks May 21, 2024
@brkalow brkalow requested a review from a team May 21, 2024 04:29
@LekoArts LekoArts merged commit 29bf434 into main May 21, 2024
10 checks passed
@LekoArts LekoArts deleted the brk.chore/repo-lint-pr-titles branch May 21, 2024 07:26
@nikosdouvlis
Copy link
Member

Nice!

nikosdouvlis added a commit that referenced this pull request May 21, 2024
So it passes the linting rules introduced in #3407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants