-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): Remove eslint-config-custom from react's deps #3307
Conversation
🦋 Changeset detectedLatest commit: da492a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think this exists as a dependency in other package.json files in the monorepo. |
Also, why doesn't this use a scoped package so there is no risk at all of downloading the published package? |
@blaine-arcjet This was the only entry under |
Are y'all planning to roll this out? It's a supply chain vulnerability in your packages |
Description
eslint-config-custom
should only be adevDependency
, not a direct dependency. This ensures we don't attempt to download the package when@clerk/clerk-react
is installed.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change