-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(express): Introduce Clerk package for Express #2918
Conversation
🦋 Changeset detectedLatest commit: 55d9b64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass at looking through the changes :)
e213120
to
3ed2a03
Compare
d771634
to
94530c5
Compare
61e0396
to
2029c38
Compare
3d62ee1
to
5ac94e9
Compare
@LekoArts, @nikosdouvlis Could you take another look at this PR? |
e13a230
to
4a035c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, some minor comments I'd like to resolve before merging
30cceb7
to
91e596a
Compare
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
… instead of implicit creation
Description
Introduce Express specific Clerk SDK
@clerk/express
. The SDK exposes the following API:clerkClient
: default @clerk/backend client initialized from env variables and used to make BAPI requestsclerkMiddleware
: centralized middleware that authenticates all requests without blocking them (also triggers handshake mechanism)getAuth
: utility to retrieve the auth state from the request (requires clerkMiddleware to executed)requireAuth
: middleware that returns http 401 response when request is signed-outAlso all the top level exports from
@clerk/backend
are re-exported from@clerk/express
top level.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
TODOs
TODO(express)
TODOs