Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Fix canary script #2803

Merged
merged 2 commits into from
Feb 15, 2024
Merged

chore(repo): Fix canary script #2803

merged 2 commits into from
Feb 15, 2024

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Feb 15, 2024

Description

With #2801 I broke the canary script 😆
Failed run: https://github.com/clerk/javascript/actions/runs/7915315607/job/21606883713

Seems like Turborepo wasn't happy with that 🤷 I tested this locally now (run npm run version:canary && npm run build) and it worked. Hopefully in CI, too

Instead of reverting the whole file, I'm just reverting the peerDependencies

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: 9e70dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review February 15, 2024 13:05
@LekoArts LekoArts enabled auto-merge February 15, 2024 13:12
@LekoArts LekoArts added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit ee95d6b Feb 15, 2024
7 checks passed
@LekoArts LekoArts deleted the fix-canary-script branch February 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants