Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): UI fixes for mobile devices in UP/OP #2730

Conversation

octoper
Copy link
Member

@octoper octoper commented Feb 5, 2024

Description

This PR applies some fixes for mobile screens to <UserProfile/> & <OrganizationProfile/>

Before:

CleanShot 2024-02-05 at 20 04 42@2x

After:

CleanShot 2024-02-05 at 20 05 47@2x

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 8d0c8d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
Copy link
Member Author

octoper commented Feb 5, 2024

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Feb 5, 2024

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Feb 06, 2024 06:28 PM

@anagstef
Copy link
Member

anagstef commented Feb 6, 2024

!preview

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper octoper force-pushed the vaggelis/sdk-1290-ui-fixes-in-mobile-devices-for-user-organization-profile branch from 6d0269d to eefa4c0 Compare February 6, 2024 18:22
@octoper
Copy link
Member Author

octoper commented Feb 6, 2024

!preview

@octoper octoper force-pushed the vaggelis/sdk-1290-ui-fixes-in-mobile-devices-for-user-organization-profile branch from eefa4c0 to 8d0c8d6 Compare February 6, 2024 21:35
@octoper octoper enabled auto-merge February 6, 2024 21:36
@octoper octoper added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 8049c04 Feb 6, 2024
@octoper octoper deleted the vaggelis/sdk-1290-ui-fixes-in-mobile-devices-for-user-organization-profile branch February 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants