fix(clerk-js): Button variants and color alignments #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 612db1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
changed the title
|
!preview |
|
Hey @desiprisg, your preview is available.
|
anagstef
requested changes
Feb 2, 2024
|
!preview |
desiprisg
force-pushed
the
george/sdk-1271-align-all-the-text-colors-including-naming-with-the-ones
branch
from
6d74b82 to
09f12ca
Compare
|
!preview |
desiprisg
force-pushed
the
george/sdk-1271-align-all-the-text-colors-including-naming-with-the-ones
branch
from
09f12ca to
e9d66db
Compare
desiprisg
changed the title
desiprisg
force-pushed
the
george/sdk-1271-align-all-the-text-colors-including-naming-with-the-ones
branch
from
e9d66db to
573d10f
Compare
|
!preview |
anagstef
approved these changes
Feb 6, 2024
| @@ -395,6 +395,7 @@ export type Elements = { | |||
| export type Variables = { | |||
| /** | |||
| * The primary color used throughout the components. Set this to your brand color. | |||
| * @default #42434D | |||
There was a problem hiding this comment.
I guess these should be wrapped in quotes '#42434D'
desiprisg
force-pushed
the
george/sdk-1271-align-all-the-text-colors-including-naming-with-the-ones
branch
from
573d10f to
612db1a
Compare
anagstef
deleted the
george/sdk-1271-align-all-the-text-colors-including-naming-with-the-ones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
variantandcolorSchemeChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore