Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements): Field Errors #2485

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat(elements): Field Errors #2485

merged 1 commit into from
Jan 4, 2024

Conversation

tmilewski
Copy link
Member

Description

  • Implements ClerkElementsError & ClerkElementsFieldError
  • Implements Field-Level Errors
  • Implements Field-Level Context for deduplication
  • Removes unnecessary Slot/asChild-esque props/logic

Notes:

  • Held back a bit on the setting of global errors so-as-to see more cases upon implementation of the First and Second factors.
  • ARIA for global errors will be handled in a future PR.

SDK-1156

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski requested a review from brkalow January 4, 2024 15:53
@tmilewski tmilewski self-assigned this Jan 4, 2024
Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 05e6646

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brkalow brkalow added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 97274c3 Jan 4, 2024
@brkalow brkalow deleted the tm.elements/field-errors branch January 4, 2024 18:34
@LekoArts LekoArts added this to the @clerk/elements (Alpha) milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants