Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-react): Use semver pkg #2011

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Nov 2, 2023

Description

Replaces the brittle logic of getPrereleaseTag and getMajorVersion with semver as it's battle-tested and will cover more of the edge cases.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 8698e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review November 2, 2023 07:43
@LekoArts LekoArts requested a review from a team as a code owner November 2, 2023 07:43
@LekoArts LekoArts added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 797e327 Nov 2, 2023
@LekoArts LekoArts deleted the lekoarts/sdk-847-use-semver-package-instead-of-regex branch November 2, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants