Update deployment_is_not_fully_available and deployment_is_fully_available for newer k8s versions
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 6 6
Lines 420 420
=======================================
Hits 346 346
Misses 74 74 Continue to review full report at Codecov.
|
Signed-off-by: Rodrigo Menezes <rodrigomenezes@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment_is_not_fully_availableanddeployment_is_fully_availableto usemetadata.namefield as a name selector as newer version of K8s no longer add a name label by defaultdeployment_is_not_fully_availableanddeployment_is_fully_availableto only uselabel_selectorif one is passed in