Skip to content

Conversation

@soos3d
Copy link
Contributor

soos3d commented Mar 19, 2024

Thank you for your contribution! Can you please give a quick rundown of what it improves? Thank you!

@hellodword
Copy link
Contributor Author

Thank you for your contribution! Can you please give a quick rundown of what it improves? Thank you!

Sure!

  • the original anchor was published in 2022, which means too old for a web3 project I guess :)
  • also, I guess keeping the same sdk version (beta) with raydium frontend is good
  • remove swapConfig and dotenv/process.env from RaydiumSwap.ts, we should only use them in the index.ts

How do you think

@soos3d
Copy link
Contributor

soos3d commented Mar 19, 2024

I think your edits make sense; thank you! I'll take a look and merge it later :)

Copy link
Member

@akegaviar akegaviar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soos3d soos3d merged commit 2e779ae into chainstacklabs:main Mar 20, 2024
Beardev118 pushed a commit to Beardev118/raydium-sdk-swap-example-typescript that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants