Skip to content

Conversation

@smypmsa
Copy link
Member

@smypmsa smypmsa commented May 12, 2025

Promoting to production

This PR promotes all changes from dev to master.

Changes included

  • Added more strict timeouts for WebSocket connection 8322ab6

Summary by CodeRabbit

  • New Features
    • Introduced consistent timeout handling for WebSocket operations, ensuring send and receive actions have a standardized timeout period.
  • Improvements
    • WebSocket connection and messaging now use fixed 10-second timeouts for improved reliability and predictability.

@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chainstack-rpc-dashboard-germany ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:23am
chainstack-rpc-dashboard-singapore ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:23am
chainstack-rpc-dashboard-us-west ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:23am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 12, 2025

Walkthrough

Timeout handling for WebSocket operations was standardized across the codebase. In common/metric_types.py, the WebSocketMetric class now uses fixed 10-second timeouts for connection phases. In metrics/ethereum.py, a default timeout constant and helper methods were introduced to wrap WebSocket send and receive calls with consistent timeout enforcement.

Changes

File(s) Change Summary
common/metric_types.py Modified WebSocketMetric.connect to use fixed 10-second values for ping_timeout, close_timeout, and added open_timeout. Removed use of configurable timeouts.
metrics/ethereum.py Added WS_DEFAULT_TIMEOUT constant. Introduced send_with_timeout and recv_with_timeout async helpers in WSBlockLatencyMetric. Refactored subscription, unsubscription, and data listening to use these helpers for consistent timeout handling.

Poem

🕰️
Timeout bunnies hop in line,
Ten seconds flat—now that’s just fine!
Sending, receiving, all with care,
No more configs hiding there.
WebSocket flows—so neat, so tight,
Rabbits code it all just right!
🐇

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@smypmsa smypmsa changed the title fix: add more strict timeouts [Promotion] Deploy dev to production (more strict timeouts) May 12, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 327a90a and 8322ab6.

📒 Files selected for processing (2)
  • common/metric_types.py (1 hunks)
  • metrics/ethereum.py (5 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
metrics/ethereum.py

146-146: Missing type annotation for function argument websocket

(ANN001)


151-153: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)


155-155: Missing type annotation for function argument websocket

(ANN001)


160-162: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

🔇 Additional comments (5)
common/metric_types.py (1)

52-54: Good standardization of WebSocket timeout values.

Replacing configurable timeouts with fixed 10-second values for ping, open, and close operations provides more consistent and predictable WebSocket behavior. This aligns well with the standardized timeout approach implemented in other parts of the codebase.

metrics/ethereum.py (4)

11-11: Good addition of a timeout constant.

Defining a constant for the default timeout value centralizes the configuration and makes it easier to maintain. This value aligns with the fixed timeouts in common/metric_types.py.


181-183: Good use of timeout wrappers for subscription.

Using the new timeout helper methods ensures consistent timeout handling when subscribing to WebSocket events.


206-207: Improved unsubscribe method with timeout wrappers and response handling.

The changes add consistent timeout handling for unsubscribe operations and properly wait for the response, which ensures the unsubscribe operation completes correctly.


221-221: Good use of timeout wrapper for data listening.

Using the new timeout helper method ensures consistent timeout handling when listening for data from the WebSocket connection.

@smypmsa smypmsa merged commit f2d96ee into master May 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants