-
Notifications
You must be signed in to change notification settings - Fork 1
[Promotion] Deploy dev to production (more strict timeouts) #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughTimeout handling for WebSocket operations was standardized across the codebase. In Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
common/metric_types.py(1 hunks)metrics/ethereum.py(5 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
metrics/ethereum.py
146-146: Missing type annotation for function argument websocket
(ANN001)
151-153: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling
(B904)
155-155: Missing type annotation for function argument websocket
(ANN001)
160-162: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling
(B904)
🔇 Additional comments (5)
common/metric_types.py (1)
52-54: Good standardization of WebSocket timeout values.Replacing configurable timeouts with fixed 10-second values for ping, open, and close operations provides more consistent and predictable WebSocket behavior. This aligns well with the standardized timeout approach implemented in other parts of the codebase.
metrics/ethereum.py (4)
11-11: Good addition of a timeout constant.Defining a constant for the default timeout value centralizes the configuration and makes it easier to maintain. This value aligns with the fixed timeouts in common/metric_types.py.
181-183: Good use of timeout wrappers for subscription.Using the new timeout helper methods ensures consistent timeout handling when subscribing to WebSocket events.
206-207: Improved unsubscribe method with timeout wrappers and response handling.The changes add consistent timeout handling for unsubscribe operations and properly wait for the response, which ensures the unsubscribe operation completes correctly.
221-221: Good use of timeout wrapper for data listening.Using the new timeout helper method ensures consistent timeout handling when listening for data from the WebSocket connection.
Promoting to production
This PR promotes all changes from dev to master.
Changes included
Summary by CodeRabbit