Skip to content

Create CONTRIBUTING.md #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2018
Merged

Create CONTRIBUTING.md #9

merged 4 commits into from
Oct 5, 2018

Conversation

ahmetcetin
Copy link
Contributor

issue #2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@thymikee
Copy link
Member

thymikee commented Oct 5, 2018

Hey @ahmetcetin, this is awesome, thanks for contribution!

However, could you make this guide a bit similar to what react-native-paper does? It's a format that works well across our repos :). You can also copy the code of conduct as well 😃

ahmetcetin and others added 3 commits October 5, 2018 17:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
how it looks now? i'll add code of conduct doc also after this. btw, i see you're in Poland, mieszkam w warszawie :)
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit 065e110 into callstack:master Oct 5, 2018
@ahmetcetin
Copy link
Contributor Author

I thank you for your open source project! this will be helpful to me, as I'm just starting a new react native project.

@ahmetcetin ahmetcetin deleted the patch-1 branch October 5, 2018 15:21
@thymikee
Copy link
Member

thymikee commented Oct 5, 2018

Cool, let me know of any shortcomings and API adjustments you think we can make. I have a couple of ideas that are tracked in this issue tracker as well.

@ahmetcetin
Copy link
Contributor Author

ahmetcetin commented Oct 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants