Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API.md #583

Closed
wants to merge 1 commit into from
Closed

Update API.md #583

wants to merge 1 commit into from

Conversation

MetaMmodern
Copy link

Shallow is removed since migration to v2.0. Mentioned here
Also no method is available after calling debug(). VSCode also shows error when trying to call shallow() after .debug or .debug()

Summary

Resolved misunderstanding in API.

Test plan

image
image
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Shallow is removed since migration to v2.0. Mentioned [here](https://callstack.github.io/react-native-testing-library/docs/migration-v2#removed-global-shallow-function)
Also no method is available after calling `debug()`. VSCode also shows error when trying to call `shallow()` after `.debug` or `.debug()`
@thymikee
Copy link
Member

debug.shallow() still works. Sounds like it's not typed correctly. Would you like to send a PR to the index.d.ts file?

@MetaMmodern
Copy link
Author

debug.shallow() still works. Sounds like it's not typed correctly. Would you like to send a PR to the index.d.ts file?

If you mean removing last 3 lines from index.d.ts then yes, I can, but I don't understand what do you mean by "is not typed correctly". Typed by me or by maintainers of rntl?

@thymikee
Copy link
Member

See #584.
Thanks for the contribution anyway!

@thymikee thymikee closed this Oct 28, 2020
@MetaMmodern
Copy link
Author

See #584.
Thanks for the contribution anyway!

I'm just new to TS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants