fix: press event order

[mdjastrzebski]

Summary

Resolves: #1687

Reverses pressOut and press event order so that it matches experimental data for regular presses:

1. pressIn,
2. (press duration)
3. pressOut
4. (no waiting) press.

The previous setup matched edge case for very short (< 130ms) presses, when order was:

1. pressIn
2. (short press duration < 130 ms)
3. press
4. (wait till 130 ms - short press duration)
5. pressOut

Scope

• Fix event order
• Prevent triggering events on unmounted components

See experiments: https://github.com/callstack/react-native-testing-library/wiki/Press-Events

Test plan

All tests pass

[mdjastrzebski]

@pierrezimmermannbam I'm messing with User Event press / longPress implementation. You might want to take a look,

[winghouchan]

@mdjastrzebski: interesting observation in regards to 'short' presses. I was able to reproduce this in my own experimentation too. Do you know if this phenomenon is documented somewhere (whether that be actual documentation or a reference to source code)?

[mdjastrzebski]

@winghouchan The best source is probably Pressability code: https://github.com/facebook/react-native/blob/33e1ae13f88979d8346e4f5ddd4cbce500a16999/packages/react-native/Libraries/Pressability/Pressability.js#L342

There is the code path when pressOut can be either executed immeditaly or delayed: https://github.com/facebook/react-native/blob/33e1ae13f88979d8346e4f5ddd4cbce500a16999/packages/react-native/Libraries/Pressability/Pressability.js#L788

Then there is the code path for press when there is no path for delay: https://github.com/facebook/react-native/blob/33e1ae13f88979d8346e4f5ddd4cbce500a16999/packages/react-native/Libraries/Pressability/Pressability.js#L757

[pierrezimmermannbam]

Nice work investigating the issue! The fix is correct but I suggested a slightly different approach

[mdjastrzebski]

This PR has been released in v12.8.1 🎉