refactor: fireEvent cleanup
#1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
requested review from
AugustinLF,
thymikee,
MattAgn and
pierrezimmermannbam
mdjastrzebski
force-pushed
the
refactor/fire-event-cleanup
branch
from
e6b2abf to
ab2b5c8
Compare
MattAgn
reviewed
May 3, 2023
MattAgn
approved these changes
May 3, 2023
|
That's some nice cleaning! 🔥 |
MattAgn
reviewed
May 3, 2023
src/fireEvent.ts
Outdated
|
|
||
| return !!element?.props.onStartShouldSetResponder || isTextInput(element); | ||
| }; | ||
| return !!element.props.onStartShouldSetResponder || isTextInput(element); |
There was a problem hiding this comment.
[nitpick] what do you think of using Boolean() instead of !! ? I find it better represents what we're doing most of the time and it's easier to read and understand
There was a problem hiding this comment.
Tbh I personally prefer !! because it's concise, but if you find Boolean() more readable we can go this way.
There was a problem hiding this comment.
both are fine for me ;) (it's just a small personal preference, also because i find !! a bit hacky ^^)
There was a problem hiding this comment.
With JS you get use to some hacking techniques over time that they feel normal ;-)
MattAgn
approved these changes
May 3, 2023
mdjastrzebski
force-pushed
the
refactor/fire-event-cleanup
branch
from
221d037 to
0d089c2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
+ Coverage 96.79% 96.85% +0.05%
==========================================
Files 51 51
Lines 3404 3398 -6
Branches 504 506 +2
==========================================
- Hits 3295 3291 -4
+ Misses 109 107 -2
☔ View full report in Codecov by Sentry. |
MattAgn
approved these changes
May 3, 2023
AugustinLF
approved these changes
May 3, 2023
|
This PR has been released in v12.1.2 🚀 |
hyochan
referenced
this pull request
in hyochan/react-native-iap
Jun 22, 2023
….2 (#2445) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@testing-library/react-native](https://callstack.github.io/react-native-testing-library) ([source](https://togithub.com/callstack/react-native-testing-library)) | [`12.0.1` -> `12.1.2`](https://renovatebot.com/diffs/npm/@testing-library%2freact-native/12.0.1/12.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>callstack/react-native-testing-library</summary> ### [`v12.1.2`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v12.1.2) [Compare Source](https://togithub.com/callstack/react-native-testing-library/compare/v12.1.1...v12.1.2) #### What's Changed #### Fixes - fix: pointer events evaluation by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1395](https://togithub.com/callstack/react-native-testing-library/pull/1395) - fix: non-editable wrapped TextInput events by [@​TMaszko](https://togithub.com/TMaszko) in [https://github.com/callstack/react-native-testing-library/pull/1385](https://togithub.com/callstack/react-native-testing-library/pull/1385) - fix: support `onXxx` event name for TextInput event checks by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1404](https://togithub.com/callstack/react-native-testing-library/pull/1404) #### Docs, Chores, etc - docs: add config example for pnpm by [@​yjose](https://togithub.com/yjose) in [https://github.com/callstack/react-native-testing-library/pull/1400](https://togithub.com/callstack/react-native-testing-library/pull/1400) - chore: move/remove deprecation functions by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1402](https://togithub.com/callstack/react-native-testing-library/pull/1402) - refactor: component tree dead code by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1403](https://togithub.com/callstack/react-native-testing-library/pull/1403) - refactor: `fireEvent` cleanup by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1401](https://togithub.com/callstack/react-native-testing-library/pull/1401) #### New Contributors - [@​yjose](https://togithub.com/yjose) made their first contribution in [https://github.com/callstack/react-native-testing-library/pull/1400](https://togithub.com/callstack/react-native-testing-library/pull/1400) 👏 - [@​TMaszko](https://togithub.com/TMaszko) made their first contribution in [https://github.com/callstack/react-native-testing-library/pull/1385](https://togithub.com/callstack/react-native-testing-library/pull/1385) 👏 **Full Changelog**: callstack/react-native-testing-library@v12.1.1...v12.1.2 ### [`v12.1.1`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v12.1.1) [Compare Source](https://togithub.com/callstack/react-native-testing-library/compare/v12.1.0...v12.1.1) #### What's Changed #### Fixes - fix: remove incorrect dependencies by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1399](https://togithub.com/callstack/react-native-testing-library/pull/1399) **Full Changelog**: callstack/react-native-testing-library@v12.1.0...v12.1.1 ### [`v12.1.0`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v12.1.0) [Compare Source](https://togithub.com/callstack/react-native-testing-library/compare/v12.0.1...v12.1.0) #### What's Changed ##### Improvements - feat: Render element tree in query error messages by [@​stevehanson](https://togithub.com/stevehanson) in [https://github.com/callstack/react-native-testing-library/pull/1378](https://togithub.com/callstack/react-native-testing-library/pull/1378) ##### Bugfixes - Proper stack trace for findBy\* and findAllBy\* queries by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1394](https://togithub.com/callstack/react-native-testing-library/pull/1394) #### New Contributors - [@​stevehanson](https://togithub.com/stevehanson) made their first contributions in [#​1377](https://togithub.com/callstack/react-native-testing-library/issues/1377), [#​1378](https://togithub.com/callstack/react-native-testing-library/issues/1378) and [#​1390](https://togithub.com/callstack/react-native-testing-library/issues/1390) 👏 ##### Chores, docs, deps, etc - Fix broken link in contributing.md by [@​stevehanson](https://togithub.com/stevehanson) in [https://github.com/callstack/react-native-testing-library/pull/1377](https://togithub.com/callstack/react-native-testing-library/pull/1377) - chore: update deps 2023-04-04 by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1380](https://togithub.com/callstack/react-native-testing-library/pull/1380) - Fix typo in "derived" in v12 migration guide by [@​CodingItWrong](https://togithub.com/CodingItWrong) in [https://github.com/callstack/react-native-testing-library/pull/1376](https://togithub.com/callstack/react-native-testing-library/pull/1376) - chore: fix migration guide role prop naming by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1382](https://togithub.com/callstack/react-native-testing-library/pull/1382) - fix: "Edit this Page" link in docs results in 404 by [@​stevehanson](https://togithub.com/stevehanson) in [https://github.com/callstack/react-native-testing-library/pull/1390](https://togithub.com/callstack/react-native-testing-library/pull/1390) - refactor: remove stale tests by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1392](https://togithub.com/callstack/react-native-testing-library/pull/1392) - chore: experiments app by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1391](https://togithub.com/callstack/react-native-testing-library/pull/1391) **Full Changelog**: callstack/react-native-testing-library@v12.0.1...v12.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/react-native-iap). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzUuMTMxLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scope:
fireEventcode before further changescallsiteargumentfireEventobject construction by removinginvokeEventonPressevent name would defeat pointer events checks forpressevent despite invoking the same handler.Test plan
Improved existing pointer event test by using both event forms
pressand `onPress.