feat: add query API #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esemesek
requested changes
Oct 7, 2018
README.md
Outdated
| @@ -282,6 +282,30 @@ test('fetch data', async () => { | |||
| }); | |||
| ``` | |||
|
|
|||
| ## `query` APIs | |||
|
|
|||
| Each of the get APIs listed in the render section above have a complimentary query API. The get APIs will throw errors if a proper node cannot be found. This is normally the desired effect. However, if you want to make an assertion that an element is not present in the DOM, then you can use the query API instead: | |||
There was a problem hiding this comment.
I think we are not using DOM here C:
src/render.js
Outdated
| @@ -30,6 +39,15 @@ export default function render( | |||
| getAllByName: getAllByName(instance), | |||
| getAllByText: getAllByText(instance), | |||
| getAllByProps: getAllByProps(instance), | |||
|
|
|||
| queryByTestId: queryByTestId(instance), | |||
There was a problem hiding this comment.
I think we should replace exports from getBy API and queryBy API by some factory function to avoid listing all the re-exports here. Eg.
// getBy.js
...
export const getByAPI (instance) => ({
queryByTestId: queryByTestId(instance),
...
});
// render.js
return {
...getByAPI(instance),
...queryByAPI(instance),
...
}
Esemesek
approved these changes
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
queryAPIs corresponding togetAPIs. For simplicity and code reuse I've decided to go with callinggetAPIs directly – as a downside we throw/catch errors twice. If this ever has a bigger perf impact we can switch the implementation.Fixes #6
Test plan
Added unit tests