-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: better support for hooks #122
Conversation
I was waiting for this! Hope current |
@Esemesek No worry. I can hold that amount of time. Thank you for the detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Would you be so kind and contribute this back to flow-typed
?
https://github.com/flow-typed/flow-typed/blob/master/definitions/npm/react-test-renderer_v16.x.x/test_react-test-renderer-v16.x.x.js
These edits are local-only, so consumers using Flow will start to get errors.
In the meantime I'll merge this, but will wait with the release just a bit
@thymikee Thanks. Hope I can get notified when this is released. |
It's up in 1.6.0, enjoy :) |
@hyochan it just just work now that all react-native-testing-library/src/__tests__/act.test.js Lines 9 to 29 in b3abf50
Apart from that, we don't have |
@thymikee Thank you so much for your attention! I get it now. |
Summary
Make testing hooks easy.
render
calls are wrapped withact
fireEvent
calls are wrapped withact
act
fromreact-test-renderer
act
function to prevent brakeable changesTest plan
Unit tests are included in PR.
Fixes #111