Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check accessibilityLabelledBy in *ByLabelText queries #1191

Merged

Conversation

pafry7
Copy link
Contributor

@pafry7 pafry7 commented Oct 20, 2022

Summary

Adds support for accessibilityLabelledBy in *ByLabelText queries as in #1183.

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @pafry7. The code looks pretty solid. I've left some comments regarding code organisation and docs.

@pafry7 pafry7 force-pushed the feat/add-accessibilityLabelledBy-support branch from 0403f18 to ecc4418 Compare October 21, 2022 08:39
@mdjastrzebski
Copy link
Member

I've added hacktoberfest-accept label to mark this PR as eligible for Hacktoberfest contribution. I plan to review it again in following days.

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pafry7 Looks pretty solid. I've added some suggestions for improvements to code and tests. Also pls rebased due to some other recent changes.

@pafry7 pafry7 force-pushed the feat/add-accessibilityLabelledBy-support branch from ecc4418 to 52f3538 Compare November 8, 2022 08:29
@mdjastrzebski
Copy link
Member

Let's pause this waiting for #1222, as it has some overlapping changes, which might be useful in this PR.

@mdjastrzebski mdjastrzebski force-pushed the feat/add-accessibilityLabelledBy-support branch from 52f3538 to 8f6bc5f Compare November 30, 2022 15:43
@mdjastrzebski
Copy link
Member

Rebased to current main.

@mdjastrzebski mdjastrzebski force-pushed the feat/add-accessibilityLabelledBy-support branch from aef1fb0 to 978865a Compare January 14, 2023 23:27
@mdjastrzebski
Copy link
Member

Rebased to main, cleaned up to account for recent code improvements in main.

@AugustinLF could you take another look at this PR?

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mdjastrzebski mdjastrzebski force-pushed the feat/add-accessibilityLabelledBy-support branch from 4502cf2 to 7e9c551 Compare January 15, 2023 22:34
@mdjastrzebski mdjastrzebski force-pushed the feat/add-accessibilityLabelledBy-support branch from 9f90370 to 9303a79 Compare January 18, 2023 10:00
@mdjastrzebski mdjastrzebski force-pushed the feat/add-accessibilityLabelledBy-support branch from d4f72be to 21acc57 Compare January 23, 2023 22:37
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 95.13% // Head: 95.19% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (d4f72be) compared to base (3b55d99).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d4f72be differs from pull request most recent head ccbe912. Consider uploading reports for the commit ccbe912 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   95.13%   95.19%   +0.06%     
==========================================
  Files          46       47       +1     
  Lines        3205     3249      +44     
  Branches      483      489       +6     
==========================================
+ Hits         3049     3093      +44     
  Misses        156      156              
Impacted Files Coverage Δ
src/helpers/matchers/matchLabelText.ts 100.00% <100.00%> (ø)
src/helpers/matchers/matchTextContent.ts 100.00% <100.00%> (ø)
src/queries/labelText.ts 100.00% <100.00%> (ø)
src/queries/testId.ts 100.00% <100.00%> (ø)
src/queries/text.ts 97.89% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants