Skip to content

fix: do not use a real timeout in waitfor when using fake timers #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 31, 2022
Merged

fix: do not use a real timeout in waitfor when using fake timers #1177

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f957246
fix: do not use a real timeout in waitfor when using fake timers
Oct 16, 2022
e9f383d
refactor: rewrite test so that it is more explicit
Oct 17, 2022
3eeefb9
refactor: make test faster by decreasing both interval and timeout
Oct 17, 2022
e6471fe
refactor: expect waitFor to throw rather than wrapping in try catch
Oct 17, 2022
417e2d8
test: fix typo in test comment
Oct 18, 2022
eaff7a6
tests: increase a bit interval so test is more robust and make it mor…
Oct 19, 2022
6686095
tests: some improvements from review
Oct 19, 2022
7297949
Update expect comment following review suggestion
pierrezimmermannbam Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: some improvements from review
  • Loading branch information
pierrezimmermann committed Oct 19, 2022
commit 6686095d0ee3bf510e7765b9c46e184641c82c97
4 changes: 2 additions & 2 deletions src/__tests__/waitFor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,15 @@ test.each([true, false])(

await expect(
async () =>
await waitFor(() => mockErrorFn(), {
await waitFor(mockErrorFn, {
timeout: WAIT_FOR_TIMEOUT,
interval: WAIT_FOR_INTERVAL,
})
).rejects.toThrow();

// Verify that even though time to perform check is longer than interval
// test won't timeout until number of checks * interval >= timeout
// ie fake timers have been advanced by timeout when waitfor rejects
// i.e. fake timers have been advanced (at least?) by timeout when waitFor rejects
expect(mockErrorFn).toHaveBeenCalledTimes(
WAIT_FOR_TIMEOUT / WAIT_FOR_INTERVAL + 1
);
Expand Down