feat: isInaccessible API form RTL/DTL
#1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
changed the title
isInaccessible API form RTL/DTL
thymikee
reviewed
Sep 19, 2022
thymikee
reviewed
Sep 19, 2022
AugustinLF
requested changes
Sep 21, 2022
Co-authored-by: Augustin Le Fèvre <augustin.le-fevre@klarna.com>
thymikee
reviewed
Sep 23, 2022
|
@AugustinLF I'd like to include this in the upcoming release, could you review it again? |
|
🎉 This PR is included in version 11.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement
isInaccessibleAPI from DTL (re-exported from RTL).This should be a useful building block for features as:
To Do
display: none&opacity: 0) + testsaccessibilityElementsHiddenwith testsimportantForAccessibilitywith testsaccessibilityViewIsModalwith testsTest plan
All checks should pass.