chore: update react-native to 0.69.1 #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jul 18, 2022
mdjastrzebski
changed the title
thymikee
reviewed
Jul 18, 2022
| jest.useFakeTimers(fakeTimerType); | ||
| const { getByText, queryByText } = render(<BananaContainer />); | ||
| test('waits for element until it stops throwing using modern fake timers', async () => { | ||
| jest.useFakeTimers('modern'); |
There was a problem hiding this comment.
We could wait for Jest 28 PR to be merged first
There was a problem hiding this comment.
So the test works, it just needs to be using two separate test entries instead of one test.each entries.
There was a problem hiding this comment.
In my testing the test worked fine when each cause had only one of modern and legacy entries, but failed when there were both of them. I have a feeling that his is somehow connected to after test cleanup since splitting tests helped.
@thymikee maybe it make more sense to you as you know more about Jest internals.
mdjastrzebski
force-pushed
the
chore/deps-react-native-0.69
branch
from
2201858 to
e4fcbf4
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for React Native 0.69.1.
Resolves #998
Test plan
All checks and tests pass.