Skip to content

implement support for resources #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guybedford merged 11 commits into from
Oct 24, 2023
Merged

implement support for resources #65

guybedford merged 11 commits into from
Oct 24, 2023

Conversation

@dicej
Copy link
Contributor

@dicej dicej commented Oct 17, 2023 •
edited
Loading

This builds on Guy's earlier, unfinished work. I've ported over all the resource tests I wrote for componentize-py and tried to make a minimal number of changes needed to get them passing.

@dicej
wip: resources
7d39314 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej dicej changed the title Resources implement support for resources Oct 17, 2023
@dicej dicej mentioned this pull request Oct 17, 2023
Closed
@guybedford guybedford mentioned this pull request Oct 17, 2023
Closed
@guybedford
Copy link

guybedford commented Oct 18, 2023

This is tremendous work, thank you @dicej for picking it up.

Now that the jco PR has been marged, we can get this CI going against the jco main branch.

Will aim to review further very soon.

guybedford
guybedford reviewed Oct 18, 2023
View reviewed changes
@guybedford
Copy link

guybedford commented Oct 19, 2023

I've released jco@0.12.2, so we can try that here now.

@dicej
Copy link
Contributor Author

dicej commented Oct 19, 2023 •
edited
Loading

I've released jco@0.12.2, so we can try that here now.

Thanks; I just pushed an update. CI will still fail due to the resource-floats test triggering the name clash in the host bindings, which I believe you're working on.

@guybedford
Copy link

guybedford commented Oct 19, 2023

Yeah, that fix will be coming in the next major which will include the WIT updates, so I wanted to get out the patch in the mean time.

@guybedford guybedford mentioned this pull request Oct 19, 2023
Merged
@guybedford
Copy link

guybedford commented Oct 23, 2023

jco@0.12.3 should fix the remaining resource generation bugs here now.

@dicej
implement support for resources
aa29fdf 
This builds on Guy's earlier, unfinished work.  I've ported over all the
resource tests I wrote for `componentize-py` and tried to make a minimal number
of changes needed to get them passing.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

switch to upstream `js-component-bindgen`

Note that package.json still uses a relative path to pull in `jco`, and my
attempt to point it to the GitHub repo failed, so I'm not sure what the next
step is there.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

update package.json to use Jco 0.12.2

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

update `jco` dependencies

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej
Copy link
Contributor Author

dicej commented Oct 23, 2023 •
edited
Loading

Just updated to jco 0.12.3. The resource-floats test is fixed, but the resource-alias-redux test is failing now, unfortunately. It seems that the generated host bindings for the test function exported by the component are wrong, but I think the code that jco 0.12.2 was generating was also wrong (just in a way that coincidentally allowed the test to pass).

dicej and others added 4 commits October 23, 2023 16:10
@dicej
implement support for resources
e0c3337 
This builds on Guy's earlier, unfinished work.  I've ported over all the
resource tests I wrote for `componentize-py` and tried to make a minimal number
of changes needed to get them passing.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej
switch to upstream js-component-bindgen
7418dab 
Note that package.json still uses a relative path to pull in `jco`, and my
attempt to point it to the GitHub repo failed, so I'm not sure what the next
step is there.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej
update package.json to use Jco 0.12.2
a5a5be1 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
updates
d9f0562
@guybedford guybedford marked this pull request as ready for review October 24, 2023 03:07
@guybedford
Copy link

guybedford commented Oct 24, 2023

@dicej I've pushed an update to this PR for jco@0.13, with the update to the latest WITs for WASI as well. I believe all tests should be passing now.

Guy Bedford and others added 4 commits October 23, 2023 22:59
node 18
e4d9d5a
node 20
f4da581
update package lock
3557a80
@dicej
update generated files
47edebd 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej
Copy link
Contributor Author

dicej commented Oct 24, 2023

I've verified that the tests are all passing now. The CI issues seem to be unrelated.

@guybedford guybedford merged commit 2d59754 into bytecodealliance:main Oct 24, 2023
@guybedford guybedford mentioned this pull request Oct 24, 2023
Closed
@Mossaka Mossaka mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@guybedford guybedford guybedford left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dicej @guybedford