aes_gcm/x86_64: Tweak gcm_ghash_vpclmulqdq_avx2_1.
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
==========================================
- Coverage 96.61% 96.60% -0.01%
==========================================
Files 180 180
Lines 21814 21814
Branches 539 539
==========================================
- Hits 21076 21074 -2
Misses 623 623
- Partials 115 117 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/aes-gcm-avx2-tweak-2
branch
from
70a769c to
cd9adfe
Compare
This was referenced Mar 12, 2025
Instead of starting with the body of the original `gcm_ghash_vpclmulqdq_avx2` and removing the multi-block support, start with `gcm_gmult_vpclmulqdq_avx2` and add the XOR of `aad`. The instruction scheduling seems a bit better. Also, this computes `bswap(Xi ^ aad)` instead of `bswap(Xi) ^ bswap(aad)`, saving one pshufb.
briansmith
force-pushed
the
b/aes-gcm-avx2-tweak-2
branch
from
cd9adfe to
c41cfcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of starting with the body of the original
gcm_ghash_vpclmulqdq_avx2and removing the multi-block support, start withgcm_gmult_vpclmulqdq_avx2and add the XOR ofaad.The instruction scheduling seems a bit better. Also, this computes
bswap(Xi ^ aad)instead ofbswap(Xi) ^ bswap(aad), saving one pshufb.