-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu::intel: Do CPU feature detection in Rust. #2439
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
+ Coverage 96.58% 96.59% +0.01%
==========================================
Files 180 179 -1
Lines 21737 21722 -15
Branches 538 523 -15
==========================================
- Hits 20995 20983 -12
- Misses 626 635 +9
+ Partials 116 104 -12 ☔ View full report in Codecov by Sentry. |
447f270
to
b5065dd
Compare
extended_features_ecx = 0; | ||
extended_features_ebx = 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As codecov points out, and the comment notes, these lines are unreachable in unpatched versions of ring. (Some people do patch it in ways that make these lines reachable.)
It's easiest to review this PR commit-by-commit.