-
-
Notifications
You must be signed in to change notification settings - Fork 94
Gp 67 new hello spring framework (for web) exercise main #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gp 67 new hello spring framework (for web) exercise main #10
Conversation
...mework/3-0-0-hello-spring-framework/src/main/java/com/bobocode/config/ApplicationConfig.java
Outdated
Show resolved
Hide resolved
...framework/3-0-0-hello-spring-framework/src/test/java/com/bobocode/ApplicationConfigTest.java
Outdated
Show resolved
Hide resolved
@Test | ||
@Order(8) | ||
@DisplayName("Find the richest account") | ||
void findRichestAccount() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathodcoast this test should not be here. It's not an application context test. We can actually remove it, since this logic is provided in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tboychuk but we don't have main
...-course-util/spring-framework-exercises-model/src/main/java/com/bobocode/model/jpa/User.java
Outdated
Show resolved
Hide resolved
...ourse-util/spring-framework-exercises-util/src/main/java/com/bobocode/TestDataGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 👍
The only critical thing that should be fixed before the merge is JPA dependency and those JPA entities
…xercise_MAIN # Conflicts: # java-web-course-util/pom.xml
No description provided.