Skip to content

Conversation

shryhus
Copy link
Contributor

@shryhus shryhus commented Apr 5, 2021

No description provided.

@shryhus shryhus requested a review from tboychuk April 5, 2021 09:50
@Test
@Order(8)
@DisplayName("Find the richest account")
void findRichestAccount() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathodcoast this test should not be here. It's not an application context test. We can actually remove it, since this logic is provided in main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboychuk but we don't have main

Copy link
Contributor

@tboychuk tboychuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍
The only critical thing that should be fixed before the merge is JPA dependency and those JPA entities

shryhus and others added 2 commits April 10, 2021 12:19
@tboychuk tboychuk merged commit 62b251f into main Apr 13, 2021
@tboychuk tboychuk deleted the GP-67_new_hello-spring-framework_(for_web)_exercise_MAIN branch April 13, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants