Skip to content

Conversation

@Nateowami
Copy link
Contributor

Clarified how to use the orientation option, and changed wording regarding the Exif parser.

Regarding the orientation option, from the original wording I thought the meaning was that you could simply enable the orientation option (e.g. by setting it to true), but from reading the source code for the demo, I see you have to determine the orientation separately with the loadImage.parseMetaData function.

On a side note, it might be worth making it an option to correct the orientation in a single function call. Fixing the orientation is the single reason I'm using this library (HTMLImageElement provides decent functionality out of the box), and I'm guessing the same could be for many others users of this library.

Thoughts on my proposed wording changes? I'm not completely happy with the wording I cam up with, but it seems clearer to me than the original wording.

@blueimp blueimp merged commit 202f10e into blueimp:master Oct 8, 2016
@blueimp
Copy link
Owner

blueimp commented Oct 8, 2016

Thanks @Nateowami, I've also just added the new options meta:true and orientation:true:
https://github.com/blueimp/JavaScript-Load-Image#options

@Nateowami
Copy link
Contributor Author

Thanks, that's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants