Skip to content

fix typo of getTapKeySigFromWithness #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix typo of getTapKeySigFromWithness #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cjs/psbt/bip371.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ function extractTaprootSigs(input) {
if (input.tapScriptSig)
sigs.push(...input.tapScriptSig.map(s => s.signature));
if (!sigs.length) {
const finalTapKeySig = getTapKeySigFromWithness(input.finalScriptWitness);
const finalTapKeySig = getTapKeySigFromWitness(input.finalScriptWitness);
if (finalTapKeySig) sigs.push(finalTapKeySig);
}
return sigs;
Expand All @@ -293,7 +293,7 @@ function extractTaprootSigs(input) {
* @param finalScriptWitness The final script witness.
* @returns The taproot signature, or undefined if not found.
*/
function getTapKeySigFromWithness(finalScriptWitness) {
function getTapKeySigFromWitness(finalScriptWitness) {
if (!finalScriptWitness) return;
const witness = finalScriptWitness.slice(2);
// todo: add schnorr signature validation
Expand Down
4 changes: 2 additions & 2 deletions src/esm/psbt/bip371.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ function extractTaprootSigs(input) {
if (input.tapScriptSig)
sigs.push(...input.tapScriptSig.map(s => s.signature));
if (!sigs.length) {
const finalTapKeySig = getTapKeySigFromWithness(input.finalScriptWitness);
const finalTapKeySig = getTapKeySigFromWitness(input.finalScriptWitness);
if (finalTapKeySig) sigs.push(finalTapKeySig);
}
return sigs;
Expand All @@ -235,7 +235,7 @@ function extractTaprootSigs(input) {
* @param finalScriptWitness The final script witness.
* @returns The taproot signature, or undefined if not found.
*/
function getTapKeySigFromWithness(finalScriptWitness) {
function getTapKeySigFromWitness(finalScriptWitness) {
if (!finalScriptWitness) return;
const witness = finalScriptWitness.slice(2);
// todo: add schnorr signature validation
Expand Down
4 changes: 2 additions & 2 deletions ts_src/psbt/bip371.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ function extractTaprootSigs(input: PsbtInput): Uint8Array[] {
if (input.tapScriptSig)
sigs.push(...input.tapScriptSig.map(s => s.signature));
if (!sigs.length) {
const finalTapKeySig = getTapKeySigFromWithness(input.finalScriptWitness);
const finalTapKeySig = getTapKeySigFromWitness(input.finalScriptWitness);
if (finalTapKeySig) sigs.push(finalTapKeySig);
}

Expand All @@ -304,7 +304,7 @@ function extractTaprootSigs(input: PsbtInput): Uint8Array[] {
* @param finalScriptWitness The final script witness.
* @returns The taproot signature, or undefined if not found.
*/
function getTapKeySigFromWithness(
function getTapKeySigFromWitness(
finalScriptWitness?: Uint8Array,
): Uint8Array | undefined {
if (!finalScriptWitness) return;
Expand Down
Loading