Skip to content

Border value not included #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Border value not included #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Border value not included 
If you're adding one to len(array)//2 then the program loosing border values of splitted half.
In your example the algorithm wouldn't find '4'.
  • Loading branch information
@gaisin
gaisin authored May 12, 2019
commit ac8c54bf912c4f99ded9fb2d39065b51ade8ef49
4 changes: 2 additions & 2 deletions binary_search/Python3/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ def binary_search(a,value):
mid=a[len(a)//2]
if value==mid: return True
if value<mid: return binary_search(a[:len(a)//2],value)
if value>mid: return binary_search(a[len(a)//2+1:],value)
if value>mid: return binary_search(a[len(a)//2:],value)


a=[1,2,3,4,5,6,7,8,9]
print(binary_search(a,5))
print(binary_search(a,5))