Skip to content

Upgrade upload-artifact and download-artifact actions to v4 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Upgrade upload-artifact and download-artifact actions to v4 #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 22 additions & 28 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:

jobs:
build:
name: Build
runs-on: macOS-latest
outputs:
TAG: ${{ steps.build-vars.outputs.TAG }}
Expand All @@ -21,26 +22,23 @@ jobs:
OPENSSL_VERSION: ${{ steps.version-details.outputs.OPENSSL_VERSION }}
strategy:
matrix:
target: ['macOS', 'iOS', 'tvOS', 'watchOS']
target: [ "macOS", "iOS", "tvOS", "watchOS" ]
steps:
- uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4.1.1

- name: Set build variables
- name: Set Build Variables
id: build-vars
env:
TAG_NAME: ${{ github.ref }}
run: |
export TAG=$(basename $TAG_NAME)
echo "TAG=${TAG}"
export PYTHON_VER="${TAG%-*}"
export BUILD_NUMBER="${TAG#*-}"

echo "PYTHON_VER=${PYTHON_VER}"
echo "BUILD_NUMBER=${BUILD_NUMBER}"

echo "TAG=${TAG}" >> ${GITHUB_OUTPUT}
echo "PYTHON_VER=${PYTHON_VER}" >> ${GITHUB_OUTPUT}
echo "BUILD_NUMBER=${BUILD_NUMBER}" >> ${GITHUB_OUTPUT}
echo "TAG=${TAG}" | tee -a ${GITHUB_OUTPUT}
echo "PYTHON_VER=${PYTHON_VER}" | tee -a ${GITHUB_OUTPUT}
echo "BUILD_NUMBER=${BUILD_NUMBER}" | tee -a ${GITHUB_OUTPUT}

- name: Set up Python
uses: actions/setup-python@v5.0.0
Expand All @@ -52,7 +50,7 @@ jobs:
# Do the build for the requested target.
make ${{ matrix.target }} BUILD_NUMBER=${{ steps.build-vars.outputs.BUILD_NUMBER }}

- name: Extract version details
- name: Extract Version Details
id: version-details
run: |
export PYTHON_VERSION=$(grep "Python version:" support/${{ steps.build-vars.outputs.PYTHON_VER }}/${{ matrix.target }}/VERSIONS | cut -d " " -f 3)
Expand All @@ -61,34 +59,30 @@ jobs:
export OPENSSL_VERSION=$(grep "OpenSSL:" support/${{ steps.build-vars.outputs.PYTHON_VER }}/${{ matrix.target }}/VERSIONS | cut -d " " -f 2)
export LIBFFI_VERSION=$(grep "libFFI:" support/${{ steps.build-vars.outputs.PYTHON_VER }}/${{ matrix.target }}/VERSIONS | cut -d " " -f 2)

echo "PYTHON_VERSION=${PYTHON_VERSION}"
echo "BZIP2_VERSION=${BZIP2_VERSION}"
echo "XZ_VERSION=${XZ_VERSION}"
echo "OPENSSL_VERSION=${OPENSSL_VERSION}"
echo "LIBFFI_VERSION=${LIBFFI_VERSION}"

echo "PYTHON_VERSION=${PYTHON_VERSION}" >> ${GITHUB_OUTPUT}
echo "BZIP2_VERSION=${BZIP2_VERSION}" >> ${GITHUB_OUTPUT}
echo "XZ_VERSION=${XZ_VERSION}" >> ${GITHUB_OUTPUT}
echo "OPENSSL_VERSION=${OPENSSL_VERSION}" >> ${GITHUB_OUTPUT}
echo "LIBFFI_VERSION=${LIBFFI_VERSION}" >> ${GITHUB_OUTPUT}
echo "PYTHON_VERSION=${PYTHON_VERSION}" | tee -a ${GITHUB_OUTPUT}
echo "BZIP2_VERSION=${BZIP2_VERSION}" | tee -a ${GITHUB_OUTPUT}
echo "XZ_VERSION=${XZ_VERSION}" | tee -a ${GITHUB_OUTPUT}
echo "OPENSSL_VERSION=${OPENSSL_VERSION}" | tee -a ${GITHUB_OUTPUT}
echo "LIBFFI_VERSION=${LIBFFI_VERSION}" | tee -a ${GITHUB_OUTPUT}

- name: Upload build artifact
uses: actions/upload-artifact@v3.1.3
- name: Upload Build Artifact
uses: actions/upload-artifact@v4.0.0
with:
name: dist
path: "dist"
name: dist-${{ matrix.target }}
path: dist
if-no-files-found: error

make-release:
name: Make Release
runs-on: ubuntu-latest
needs: build
steps:
- name: Get build artifacts
uses: actions/download-artifact@v3.0.2
uses: actions/download-artifact@v4.1.0
with:
name: dist
pattern: dist-*
path: dist
merge-multiple: true

- name: Create Release
uses: ncipollo/release-action@v1.13.0
Expand Down