-
Notifications
You must be signed in to change notification settings - Fork 127
Add translation strategy #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation strategy #234
Conversation
|
Can we move the translations document to the docs folder as a markdown file? https://github.com/bbcmicrobit/PythonEditor/tree/v2-beta/docs |
TRANSLATIONS.rst
Outdated
| 1.3 Syncing Translations | ||
| ++++++++++++++++++++++++ | ||
| Crowdin can perform a sync between itself and Github, meaning that we can pass language updates either way. This | ||
| is currently triggered manually. When a new release of the editor is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like this also takes into account beta release?
If that's the case then each beta release would be deployed without translations for the new strings, and the translation would only be deploted by the next beta release?
I think this is fine, but it does mean there is a delay between releasing a feature and having the translations available.
Also, if there were any primary releases that bypass the beta release, we might need to manage that differently, but we can cross that bridge when we come it it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay if I understand your concern correctly. eg
- new beta feature added and strings updated in en.js
- beta feature released with new strings only in english
- Translation work can happen on the new strings from this point
The feature can be released with partial/full translation in available languages
Perhaps we should note that features in beta are experimental, so translation efforts should be focussed on the live editor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wrote this before I read the following sections, which I interpreted as "the strings will only be updated into Crowdin once they are officially "frozen" (likely at the first RC release)".
I left the comment because I am not quite sure when we will be updating the strings. Doing it only at RC is fine, but it means that any new/updated strings in the Beta Editor will always be available in english only, as they will only be frozen when an RC is ready, and at that point the release into the main editor will be imminent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment and https://github.com/bbcmicrobit/PythonEditor/pull/234/files/d14b75aefe8eb5a80b4cbf4aeff04e7660d9fa1f#diff-62acef342617ece5a91fe47442d38d91 still need to implemented?
TRANSLATIONS.rst
Outdated
| are suitably maintained. Enabled languages can be found in the Crowdin | ||
| project. For the Python Editor, we expect the **source strings to be | ||
| 100% translated and proofread** before they are made public as a | ||
| released language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should emphasise that we appreciate all volunteers contributions and a single user doesn't have to do the entire translation. Every little helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph looks the same, has some clarification been added somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the heading I've called out more about the great work of translators "Translations for all the Micro:bit Educational Foundation’s editors and apps are contributed by an amazing team of volunteers and we’d love for you to be a part of this too." and
Under 1.2 " It also makes it easy for lots of people to contribute to the translation process, rather than one person being responsible for a language."
I thought those places might be more appropriate context for this than under "Available languages"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my original comment was more about that when looking at this paragraph perhaps readers could misinterpret it and think that if they want to contribute they have to provide 100% of the translation, which might put off translators that could still do smaller contributions. So maybe we can clarify that here?
|
Sam has reviewed in https://github.com/microbit-foundation/platform-software-issue-tracker/issues/410#issuecomment-535957479 so I think this is good to go |
microbit-carlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks Mark!
@jaustin for final review
closes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/410