Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal for #245 #246

Merged
merged 2 commits into from
Oct 17, 2022
Merged

proposal for #245 #246

merged 2 commits into from
Oct 17, 2022

Conversation

seancorfield
Copy link
Collaborator

clojure.spec.alpha -> s

Show idiomatic by last segment, idiomatic by shorter alias, some third-party aliases.

@seancorfield
Copy link
Collaborator Author

In addition to clojure.spec.alpha being s rather than spec, I've changed clojure.core.async to async (as an example of using the last segment because I've never seen anyone suggesting as -- although it's a namespace where people commonly :refer in various operator-like functions so you sometimes see it used without an alias at all).

I also added clojure.core.protocols as p -- I trust that is not controversial.

bbatsov
bbatsov approved these changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sheluchin sheluchin mentioned this pull request Oct 16, 2022
Closed
@seancorfield seancorfield merged commit 1888895 into master Oct 17, 2022
@seancorfield seancorfield deleted the issue-245 branch October 17, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbatsov bbatsov bbatsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seancorfield @bbatsov