when vs if clarification #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original "Use when instead of (if … (do …))" made me skip it because I did not have a `do` in my code, only `(if cond something...)`. So I want to clarify that it applies to all single-branch ifs, no matter whether they use do or not.
|
I'm strongly in favor of this guideline but I'm not sure the change really clarifies it since it still shows only if/do - I think it should also add "or |
|
I agree - more examples would probably be better than rewording the guideline. |
|
Added an example. I still think it is clearer with a little more explanatory text than the original guideline so I left it there. Feel free to remove if you disagree. |
|
I'm good with that. @bbatsov ? |
|
Fine by me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original "Use when instead of (if … (do …))" made me skip it because I did not have a
doin my code, only(if cond something...). So I want to clarify that it applies to all single-branch ifs, no matter whether they use do or not.