Fix cycles with some dependencies with gradle resolver #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471. There's more detail there about the issue.
Make sure we don't traverse the dependency constraint edges while navigating the dependencies and create a cycle. This now succeeds. On
master, if you add"androidx.fragment:fragment-ktx:1.6.1"and build after regenerating the lockfile the build fails due to many cycles.Updated the regression test, checking if unit test passes and also will look into adding a "full" unit test with some example dependencies having these constraints.