Untangle resolvers #1458
Merged
Untangle resolvers #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
approved these changes
Oct 7, 2025
Until now the `maven` and `gradle` resolvers have been linked into the same binary. While this is convenient, it means that people need to download dependencies they won't otherwise use. This change breaks the resolvers into their own `java_binary` targets so that they can be referenced individually, thus reducing the amount of dependencies that need to be downloaded before resolution can begin. After this change: bazel query 'somepath(@regression_testing_maven//:pin, @gradle//...:*)' returns an empty set.
shs96c
force-pushed
the
separate-resolvers
branch
from
bb430da to
c980abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the
mavenandgradleresolvers have been linked into the same binary. While this is convenient, it means that people need to download dependencies they won't otherwise use.This change breaks the resolvers into their own
java_binarytargets so that they can be referenced individually, thus reducing the amount of dependencies that need to be downloaded before resolution can begin.After this change:
returns an empty set.
Closes #1455