chore: make root workspace buildable #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
publish_bcr
branch
2 times, most recently
from
f961f5d to
e23787d
Compare
replaces previous PR which tried to workaround this. Remove rules_lint - the reasoning is we want this repo to be simpler since it's a common dependency for users to visit, and also our code is in Go but rules_lint has no Go linters
kormide
approved these changes
Apr 22, 2025
Therefore there's a + (or earlier ~) character appended on the end of the value we compare against. This seems undesirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces previous PR which tried to workaround this. Remove rules_lint - the reasoning is we want this repo to be simpler since it's a common dependency for users to visit, and also our code is in Go but rules_lint has no Go linters