Skip to content

test: Correcting cloudformation export tests to use yaml.safe_load() #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged

test: Correcting cloudformation export tests to use yaml.safe_load() #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def test_list_workflows(client):

def test_cloudformation_export_with_simple_definition(workflow):
cfn_template = workflow.get_cloudformation_template()
cfn_template = yaml.load(cfn_template)
cfn_template = yaml.safe_load(cfn_template)
assert 'StateMachineComponent' in cfn_template['Resources']
assert workflow.role == cfn_template['Resources']['StateMachineComponent']['Properties']['RoleArn']
assert cfn_template['Description'] == "CloudFormation template for AWS Step Functions - State Machine"
Expand Down Expand Up @@ -300,7 +300,7 @@ def test_cloudformation_export_with_sagemaker_execution_role(workflow):
}
})
cfn_template = workflow.get_cloudformation_template(description="CloudFormation template with Sagemaker role")
cfn_template = yaml.load(cfn_template)
cfn_template = yaml.safe_load(cfn_template)
assert json.dumps(workflow.definition.to_dict(), indent=2) == cfn_template['Resources']['StateMachineComponent']['Properties']['DefinitionString']
assert workflow.role == cfn_template['Resources']['StateMachineComponent']['Properties']['RoleArn']
assert cfn_template['Description'] == "CloudFormation template with Sagemaker role"