-
Notifications
You must be signed in to change notification settings - Fork 942
feature: Support of ReturnConsumedCapacity in DynamoDBEnhancedClient's TransactWriteItem operation #5501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Support of ReturnConsumedCapacity in DynamoDBEnhancedClient's TransactWriteItem operation #5501
Conversation
I'll be your PR reviewer! Once #5462 is shipped, feel free to update this PR with to fix any matching comments. Hopefully once that one is done, this one will go quick. |
11650bd
to
9dded9f
Compare
I had a few comments, but to help communicate them I just created a commit on top of yours for comparison: 4d5c584 I made these changes:
If you're cool with those changes, you can cherry-pick the commit and I'll give the ship-it tomorrow! Otherwise, let's talk about it. |
…-item' into consumed-capacity-transact-write-item
Thanks for making these changes. They look great to me.
Thanks a lot, @millems , appreciate your help! I've pulled in your changes |
|
Thanks for your contribution! It will go out with the next regularly-schedule SDK release, some time next week. |
@millems I may have missed running the changelog script. Does that affect the release of these changes? |
Motivation and Context
Currently the response returned by
TransactWriteItem
operations don't return the Capacity consumed unlike some other requests. This PR introduces that featureOpen issue: #4123
Modifications
Testing
Added unit tests and functional tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License