Skip to content

Conversation

preearor
Copy link
Contributor

  • It impacted the error message in case user handler name is a/module1.handler, and the module was not found it would raise error as a.module1 not found rather than a/module1 is not found. Corrected this behavior

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@preearor preearor requested review from carlzogh and keshayad June 25, 2021 18:05
@carlzogh
Copy link
Contributor

Let's also add a test to assert that such error messages contain the original handler notation too 😀

@carlzogh carlzogh added the semver-patch Requires a patch semantic versioning bump label Jun 26, 2021
Copy link
Contributor

@keshayad keshayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@preearor preearor merged commit 149ce3a into aws:main Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Requires a patch semantic versioning bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants