Skip to content

Conversation

@pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Oct 1, 2020

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pankajagrawal16 pankajagrawal16 changed the title Prepare for 0.4.0-beta ci: Prepare for 0.4.0-beta Oct 1, 2020
<version>0.3.1-beta</version>
<version>0.4.0-beta</version>
</dependency>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make me think I forgot to add this in the parameters doc (installation step):

<dependency>
    <groupId>software.amazon.lambda</groupId>
    <artifactId>powertools-parameters</artifactId>
    <version>0.4.0-beta</version>
</dependency>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha.. nevermind, I can fix it in same PR

<version>0.3.1-beta</version>
<version>0.4.0-beta</version>
</dependency>
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics is not there? normal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I guess we missed updating it when we launched metrics module 😉

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pankajagrawal16 pankajagrawal16 merged commit febb426 into master Oct 2, 2020
@pankajagrawal16 pankajagrawal16 deleted the 0.4.0-beta branch October 2, 2020 07:44
jeromevdl pushed a commit to jeromevdl/aws-lambda-powertools-java that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants