Skip to content

Conversation

@mahi0601
Copy link

@mahi0601 mahi0601 commented Jan 5, 2021

#175
I have changed the color and geometry . Now it can be maximized. I have adjust the sizes of the buttons and color of the text in the button. Now you can increase the size or et a better view with maximizing the screen.

Description

I have fixed the maximizing issue of the screen

Fixes #(175)

Replace 175 with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • [X ] Yes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ X] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.
    1

I have changes the color and geometry . Now it can be resizeable or maximized.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@mahi0601
Copy link
Author

mahi0601 commented Jan 7, 2021

It's been two days but the checking hasn't passed yet

@avinashkranjan
Copy link
Owner

avinashkranjan commented Jan 8, 2021

Resolve the Conflicts and What Difference does that maximize button make.. It was disabled cause it didn't have any purpose.. If you are working on that issue the maximize button to maximize the calculator along with the buttons. @mahi0601

@mahi0601
Copy link
Author

mahi0601 commented Jan 8, 2021

No I was trying to just enable the maximizing button

@avinashkranjan
Copy link
Owner

No I was trying to just enable the maximizing button

It didn't have any purpose so it was disabled..Would you work on maximizing function or should I close this and you can work on some other issue

@mahi0601
Copy link
Author

mahi0601 commented Jan 8, 2021

No close this issue I will work on others

@avinashkranjan avinashkranjan added the invalid This doesn't seem right label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants