Skip to content

Conversation

@adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Jun 22, 2023

Changes

Asyncifying authentication classes doesn't work because the asyncify method was assuming the wrong signature.

References

fixes #498

Testing

AsyncGetToken = asyncify(GetToken)

get_token = AsyncGetToken(domain, client_id)

response = await self.get_token.login_async(
    username=username,
    password=password,
    realm="Username-Password-Authentication",
    scope="openid profile email",
)

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 22, 2023 12:38
@adamjmcgrath adamjmcgrath added the review:small Small review label Jun 22, 2023
@adamjmcgrath adamjmcgrath merged commit 0bf0176 into master Jun 26, 2023
@adamjmcgrath adamjmcgrath deleted the fix-async-auth branch June 26, 2023 14:30
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:small Small review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetToken and asyncify: Algorithm not supported

3 participants