Skip to content
This repository was archived by the owner on Apr 7, 2021. It is now read-only.

Adds support to Laravel 5.7 #29

Closed
wants to merge 1 commit into from
Closed

Conversation

ben182
Copy link

@ben182 ben182 commented Sep 6, 2018

No description provided.

@ben182
Copy link
Author

ben182 commented Sep 6, 2018

#28 fix

@axelitus
Copy link

axelitus commented Sep 7, 2018

The tests are failing but I don't think is related (because the unchanged code is still throwing this error). The tests fail in this line:

$this->assertEquals($model->getOriginal('should_be_encrypted'), $new_model->getOriginal('should_be_encrypted'));

No other test fails, so this "should" be safe to merge.

@jasonlbeggs
Copy link

Any update on when this will be fixed/merged? I am working on upgrading an app to Laravel 5.7.

@austinheap
Copy link
Owner

No promises on when I'll have time to dig into why the tests are failing but you can override the composer.json dependency with your own branch.

@axelitus
Copy link

axelitus commented Sep 13, 2018

Hopefully, you can get the time to revise the code soon though ;)

@austinheap
Copy link
Owner

Closing in place of 573112a. Feedback please! 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants