This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix heredoc expansion #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@darangi Could this be merged? |
|
You might find my bug report interesting: #165 |
|
why is still open? same issue in vscode |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add support for recognizing expansions in heredocs. The
beginregexes of the existing rules are modified to not match the expanded form (which doesn't have quotes, see here). New rules for the expanded form are added that are identical to the existing ones minus the quotes. Thepatternsare taken from'string'(minus the quotes).Alternate Designs
None
Benefits
Variables in shell script heredocs will be correctly highlighted.
Possible Drawbacks
None
Applicable Issues
#151