Skip to content

Set severity for IDE0005 to warning and add doc file #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Set severity for IDE0005 to warning and add doc file #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions distribution/dotnet7/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ dotnet_diagnostic.CA1014.severity = none # https://github.com/atc-net
dotnet_diagnostic.CA1068.severity = error # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/CA1068.md
dotnet_diagnostic.CA1707.severity = error # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/CA1707.md
dotnet_diagnostic.CA2007.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/CA2007.md
dotnet_diagnostic.IDE0005.severity = warning # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/IDE0005.md
dotnet_diagnostic.IDE0058.severity = none # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/IDE0058.md


Expand Down
21 changes: 21 additions & 0 deletions documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/IDE0005.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Rule adding suggestion - Decision

### Rule summary

| | Value |
| ----------- |------------------------------------------------|
| Title | IDE0005 Remove unnecessary using directives |
| CheckId | IDE0005 |
| Category | Style |
| Link | https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0005 |

### What is the problem
This rule detects unused usings which can simply be removed. This rule is currently not a part of our coding rules and it should be.

### Decision

We update the `root/.editorconfig` with `severity = warning` and a doc-link.

### Reason & arguments

* This rule detects code that can be removed and no code is better than no code - see dissuction in [Issue #74](https://github.com/atc-net/atc-coding-rules/issues/74).