Add explanatory comment re: release asset upload warning #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subfolders that remain in the Go release system's build output cause a bunch of warnings in the workflow run summary and logs resulting from the step that uploads the archives as release assets: ``` Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_32bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_64bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARM64/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARMv6/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARMv7/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_macOS_64bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Windows_32bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Windows_64bit/. Directories can not be uploaded to a release. ``` There is no problem because these subfolders are not intended to be added as release assets and the archives in the root of the dist folder are uploaded, but I think these warnings might cause someone confusion far in the future when nobody remembers exactly how these workflows work and wonders if these warnings indicate something is wrong. I didn't find a clean solution for adjusting the artifacts input glob to exclude the subfolders so I settled on adding an explanatory comment to the workflow.
per1234
added
topic: documentation
silvanocerza
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subfolders that remain in the Go release system's build output cause a bunch of warnings in the workflow run summary and logs resulting from the step that uploads the archives as release assets:
There is no problem because these subfolders are not intended to be added as release assets and the archives in the root of the
distfolder are uploaded, but I think these warnings might cause someone confusion far in the future when nobody remembers exactly how these workflows work and wonders if these warnings indicate something is wrong.I didn't find a clean solution for adjusting the artifacts input glob to exclude the subfolders so I settled on adding an explanatory comment to the workflow.
Previous discussion and approval for this change: arduino/serial-discovery#18 (review)