Skip to content

Change dependencies management #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Change dependencies management #11

merged 4 commits into from
Jul 30, 2020

Conversation

silvanocerza
Copy link
Contributor

This PR changes how dependencies are handled in the project, node_modules are not commited anymore but we use zeit/ncc to handle packaging for distribution. This way of managing deps is easier and less prone to error since we don't risk commit node_modules not necessary for production.
See the official docs on JS Actions creation for more information.

I've also changed the package.json version to the current one and updated some dependencies.

@silvanocerza silvanocerza added topic: documentation Related to documentation for the project dependencies labels Jul 30, 2020
@silvanocerza silvanocerza requested a review from a team July 30, 2020 12:35
@silvanocerza silvanocerza self-assigned this Jul 30, 2020
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@silvanocerza silvanocerza merged commit 051108c into master Jul 30, 2020
@silvanocerza silvanocerza deleted the scerza/deps-handling branch July 30, 2020 14:05
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed dependencies labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants