Updated DistTask.yml / Add support for macos_ARM64 builds #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
3 tasks
Member
Author
|
I've made a test build and it seems working as expected. |
Contributor
|
Are we 100% sure that CGO is not required? Have you tested if the monitor works correctly on linux/macos? |
alessio-perugini
approved these changes
Feb 21, 2024
alessio-perugini
left a comment
alessio-perugini
left a comment
There was a problem hiding this comment.
I've tested on Linux and it's working fine. At the moment I don't have other OSs to test it.
Member
Author
Yes, CGO is needed only for the USB enumerator on macOS. |
umbynos
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated
DistTask.ymlhas been taken from the Arduino CLI project.